[tests] remove `test_pipelines_common.py` by sayakpaul · Pull Request #14669 · huggingface/diffusers

sayakpaul · 2026-09-01T04:46:22Z

Move FluxIPAdapterTesterMixin to the IP Adapter testing utils since it's shared by more than Flux.
Migrate old imports in the test suites of DeepFloyd IF, etc. to use new ones.
Migrate the Stable Diffusion Adapter test suite to use new mixins.
Remove test_pipelines_common.py.

sayakpaul · 2026-09-01T05:44:27Z

+# support `"pt"`; adding that here is a `src/` change and out of scope for this test migration, so the affected
+# tests are marked `xfail` rather than skipped: whoever adds the `"pt"` branch will see them XPASS and can drop
+# these markers.
+NO_PT_OUTPUT = pytest.mark.xfail(


Open to other ideas but I chose to xfail these tests and not introduce anything really new to our shared tester mixins.

sayakpaul · 2026-09-01T06:27:47Z

/diffusers-bot pytest tests/pipelines/stable_diffusion_adapter/test_stable_diffusion_adapter.py

github-actions · 2026-09-01T06:28:03Z

✅ pytest tests/pipelines/stable_diffusion_adapter/test_stable_diffusion_adapter.py passed on GPU — view logs.

sayakpaul · 2026-09-01T06:45:24Z

/diffusers-bot pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference

github-actions · 2026-09-01T06:45:33Z

⚠️ pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference was cancelled on GPU — view logs.

sayakpaul · 2026-09-01T06:45:48Z

/diffusers-bot pytest tests/pipelines/consisid/test_consisid.py tests/pipelines/stable_audio/test_stable_audio.py

github-actions · 2026-09-01T06:46:18Z

✅ pytest tests/pipelines/consisid/test_consisid.py tests/pipelines/stable_audio/test_stable_audio.py passed on GPU — view logs.

sayakpaul · 2026-09-01T07:08:15Z

/diffusers-bot pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference

github-actions · 2026-09-01T07:08:27Z

✅ pytest tests/pipelines/stable_diffusion_2/test_stable_diffusion_depth.py::TestStableDiffusionDepth2ImgPipelineMemory::test_group_offloading_inference passed on GPU — view logs.

sayakpaul · 2026-09-03T07:08:39Z

          pytest -n 1 --max-worker-restart=0 --dist=loadfile \
            --make-reports=tests_torch_minimum_version_cuda \
            tests/models/test_modeling_common.py \
-            tests/pipelines/test_pipelines_common.py \


No longer exists.

sayakpaul · 2026-09-03T07:08:59Z

-      - "tests/pipelines/test_pipelines_common.py"
+      - "tests/pipelines/testing_utils/**.py"
      - "tests/models/test_modeling_common.py"
+      - "tests/models/testing_utils/**.py"


To have parity in our CI when test changes happen.

sayakpaul · 2026-09-03T07:09:06Z

          pytest -n 1 --max-worker-restart=0 --dist=loadfile \
            --make-reports=tests_torch_minimum_cuda \
            tests/models/test_modeling_common.py \
-            tests/pipelines/test_pipelines_common.py \


No longer exists.

sayakpaul · 2026-09-03T07:12:04Z

+)
+
+
+class AdapterPipelineTesterConfig(BasePipelineTesterConfig):


The remaining test suite being refactored.

sayakpaul · 2026-09-03T07:29:35Z

/diffusers-bot pytest tests/pipelines/kandinsky/ tests/pipelines/kandinsky2_2/

github-actions · 2026-09-03T07:29:45Z

✅ pytest tests/pipelines/kandinsky/ tests/pipelines/kandinsky2_2/ passed on GPU — view logs.

hf-security-analysis · 2026-09-16T05:51:02Z

⚠️ Workflow security review — 20 high, 15 medium

Scanned 3 workflow file(s) with zizmor, pinact, OSV/GHSA, Claude, in full.

`.github/workflows/nightly_tests.yml`

⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:34 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:71 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:117 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:189 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:233 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:282 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:355 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:411 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/nightly_tests.yml:469 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
🟡 MEDIUM template-injection — .github/workflows/nightly_tests.yml:97 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/nightly_tests.yml:98 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/nightly_tests.yml:99 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/nightly_tests.yml:103 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/nightly_tests.yml:104 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.

`.github/workflows/pr_tests_gpu.yml`

⚠️ HIGH unpinned-images — .github/workflows/pr_tests_gpu.yml:91 (via zizmor)
unpinned image references — container image uses the floating 'latest' tag

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/pr_tests_gpu.yml:130 (via zizmor)
unpinned image references — container image uses the floating 'latest' tag

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/pr_tests_gpu.yml:194 (via zizmor)
unpinned image references — container image uses the floating 'latest' tag

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/pr_tests_gpu.yml:264 (via zizmor)
unpinned image references — container image uses the floating 'latest' tag

Fix: unpinned image references
🟡 MEDIUM template-injection — .github/workflows/pr_tests_gpu.yml:164 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/pr_tests_gpu.yml:166 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/pr_tests_gpu.yml:167 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/pr_tests_gpu.yml:172 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/pr_tests_gpu.yml:179 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/pr_tests_gpu.yml:180 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.

`.github/workflows/release_tests_fast.yml`

⚠️ HIGH unpinned-images — .github/workflows/release_tests_fast.yml:34 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/release_tests_fast.yml:74 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/release_tests_fast.yml:119 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/release_tests_fast.yml:176 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/release_tests_fast.yml:234 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/release_tests_fast.yml:277 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
⚠️ HIGH unpinned-images — .github/workflows/release_tests_fast.yml:320 (via zizmor)
unpinned image references — container image is unpinned

Fix: unpinned image references
🟡 MEDIUM template-injection — .github/workflows/release_tests_fast.yml:100 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/release_tests_fast.yml:101 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/release_tests_fast.yml:105 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.
🟡 MEDIUM template-injection — .github/workflows/release_tests_fast.yml:106 (via zizmor)
code injection via template expansion — may expand into attacker-controllable code

Fix: Map the expression into the step's env: block and reference the shell variable instead of interpolating it into run:.

ℹ️ No change could be applied automatically.

Pinning and static findings are deterministic. Findings marked (via Claude) are model judgements — check them before acting.

fix(ci): harden workflow files flagged on #14669 Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com>

migrate imports

b4e6819

github-actions Bot added tests size/L PR with diff > 200 LOC labels Sep 1, 2026

migrate stable diffusion adapter tests

c02fb4c

sayakpaul commented Sep 1, 2026

View reviewed changes

up

5b1597b

sayakpaul commented Sep 1, 2026

View reviewed changes

Comment thread tests/pipelines/testing_utils/memory.py Outdated

sayakpaul commented Sep 1, 2026

View reviewed changes

Comment thread tests/pipelines/kandinsky/test_kandinsky_prior.py Outdated

move last remaining bits.

a622a87

github-actions Bot added the CI label Sep 1, 2026

sayakpaul added 5 commits September 1, 2026 07:32

simplify test policy wording

7511684

move around

d75be5b

Merge branch 'main' into remove-test-pipelines-common

38c91e4

Merge branch 'main' into remove-test-pipelines-common

ba560b5

resolve conflicts

7252c84

sayakpaul commented Sep 3, 2026

View reviewed changes

Merge branch 'main' into remove-test-pipelines-common

59f2651

DN6 reviewed Sep 10, 2026

View reviewed changes

Comment thread tests/pipelines/testing_utils/ip_adapter.py Outdated

Comment thread tests/pipelines/flux/testing_utils.py

sayakpaul added 2 commits September 11, 2026 07:20

Merge branch 'main' into remove-test-pipelines-common

659afc2

move flux ip adapter testing stuff to flux module of test

05b9ddc

sayakpaul requested a review from DN6 September 11, 2026 05:28

sayakpaul added 2 commits September 13, 2026 16:53

Merge branch 'main' into remove-test-pipelines-common

dadd95a

Merge branch 'main' into remove-test-pipelines-common

79ac94e

hf-security-analysis Bot added a commit that referenced this pull request Sep 16, 2026

fix(ci): harden workflow files flagged on #14669

2e3dfb7

hf-security-analysis Bot mentioned this pull request Sep 16, 2026

fix(ci): harden GitHub Actions workflows (#14669) #14787

Merged

fix(ci): harden GitHub Actions workflows (#14669) (#14787)

6c269d5

fix(ci): harden workflow files flagged on #14669 Co-authored-by: hf-security-analysis[bot] <265538906+hf-security-analysis[bot]@users.noreply.github.com>

		)


		class AdapterPipelineTesterConfig(BasePipelineTesterConfig):

Conversation

sayakpaul commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sayakpaul Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

sayakpaul commented Sep 1, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sayakpaul commented Sep 1, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sayakpaul commented Sep 1, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sayakpaul commented Sep 1, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sayakpaul Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

sayakpaul Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

sayakpaul Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sayakpaul Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

sayakpaul commented Sep 3, 2026

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hf-security-analysis Bot commented Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Workflow security review — 20 high, 15 medium

.github/workflows/nightly_tests.yml

.github/workflows/pr_tests_gpu.yml

.github/workflows/release_tests_fast.yml

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sayakpaul commented Sep 1, 2026 •

edited

Loading

github-actions Bot commented Sep 1, 2026 •

edited

Loading

github-actions Bot commented Sep 1, 2026 •

edited

Loading

github-actions Bot commented Sep 1, 2026 •

edited

Loading

github-actions Bot commented Sep 1, 2026 •

edited

Loading

sayakpaul Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading

hf-security-analysis Bot commented Sep 16, 2026 •

edited

Loading

`.github/workflows/nightly_tests.yml`

`.github/workflows/pr_tests_gpu.yml`

`.github/workflows/release_tests_fast.yml`